Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34359 )
Change subject: mainboard: Add Lenovo ThinkPad T440p ......................................................................
Patch Set 12: Code-Review+1
(3 comments)
Minor not in the devicetree.cb, but LGTM.
https://review.coreboot.org/c/coreboot/+/34359/12/Documentation/mainboard/le... File Documentation/mainboard/lenovo/t440p.md:
https://review.coreboot.org/c/coreboot/+/34359/12/Documentation/mainboard/le... PS12, Line 38: - Cannot get the mainboard serial number Are there any eeproms on smbus?
https://review.coreboot.org/c/coreboot/+/34359/12/src/mainboard/lenovo/t440p... File src/mainboard/lenovo/t440p/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34359/12/src/mainboard/lenovo/t440p... PS12, Line 39: register "gen3_dec" = "0x00000000" remove
https://review.coreboot.org/c/coreboot/+/34359/12/src/mainboard/lenovo/t440p... File src/mainboard/lenovo/t440p/romstage.c:
https://review.coreboot.org/c/coreboot/+/34359/12/src/mainboard/lenovo/t440p... PS12, Line 36: RCBA_RMW_REG_32(FD, ~0, PCH_DISABLE_ALWAYS), If you want, you can put this in a common location (like broadwell).