Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46962 )
Change subject: mb/google/hatch/jinlon: Describe the privacy_gpio ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46962/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/jinlon/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46962/2/src/mainboard/google/hatch/... PS2, Line 86: ACPI_GPIO_INPUT_ACTIVE_LOW
I tried setting PAD_RX_POL(INVERT) on an EDGE_BOTH and it had no effect (check the attached patch). […]
Thanks for the pointers Ricardo. It is definitely an interesting case. As for why the above diff did not work, I think the kernel is reconfiguring the pad based on the information passed in ACPI. That is probably why it doesn't work. If interested, you can dump the configuration registers in coreboot and kernel to see if they change later on. Anyways, we can go ahead with the change you have in the latest patchset. Thanks for trying this out! :)
https://review.coreboot.org/c/coreboot/+/46962/4/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/jinlon/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46962/4/src/mainboard/google/hatch/... PS4, Line 83: Can you please use tabs instead of spaces here and for the lines below like the rest of the entries in this file?
https://review.coreboot.org/c/coreboot/+/46962/4/src/mainboard/google/hatch/... PS4, Line 87: ACPI_GPIO_INPUT_ACTIVE_LOW Can you please add a comment here explaining why this is being configured as GPIO instead of GPIO_IRQ? It would be good to have the context here so that it isn't accidentally changed later on and also helps if anyone decides to copy-paste.