Attention is currently required from: Shelley Chen, Ravi kumar. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53902 )
Change subject: sc7280: Add PCIe RC driver in Coreboot ......................................................................
Patch Set 8:
(26 comments)
File src/soc/qualcomm/sc7280/include/soc/addressmap.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119815): https://review.coreboot.org/c/coreboot/+/53902/comment/f0a9d438_8dbb9b5d PS8, Line 68: #define PCIE1_MEM_SIZE 0x1fd00000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119815): https://review.coreboot.org/c/coreboot/+/53902/comment/8e340105_3176029c PS8, Line 69: #define PCIE_MEM_END 0x404fffff please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119815): https://review.coreboot.org/c/coreboot/+/53902/comment/281893d5_1da839e6 PS8, Line 72: #define PCIE_1_QMP_PHY 0x01C0E000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119815): https://review.coreboot.org/c/coreboot/+/53902/comment/72c34f06_b7a6ae35 PS8, Line 76: #define PCE1_QPHY_SERDES 0x01C0E000 please, no space before tabs
File src/soc/qualcomm/sc7280/include/soc/pcie.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119815): https://review.coreboot.org/c/coreboot/+/53902/comment/e6861ec8_7f5c6f0a PS8, Line 18: #define DEV_ID_SZ 16 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119815): https://review.coreboot.org/c/coreboot/+/53902/comment/dd14fe79_6c7c30d0 PS8, Line 19: #define CLASS_SZ 16 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119815): https://review.coreboot.org/c/coreboot/+/53902/comment/d21db0d5_7e966f87 PS8, Line 20: #define HEADER_SZ 8 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119815): https://review.coreboot.org/c/coreboot/+/53902/comment/704b53d9_572d67b9 PS8, Line 21: #define VEND_ID_SZ 16 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119815): https://review.coreboot.org/c/coreboot/+/53902/comment/cb87f133_ed8c334c PS8, Line 25: #define PCIE_CLASS 0x0a please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119815): https://review.coreboot.org/c/coreboot/+/53902/comment/10443a08_e106762f PS8, Line 26: #define PCI_MAX_DEV_FN 0x100 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119815): https://review.coreboot.org/c/coreboot/+/53902/comment/04bf6b9e_8ba42b14 PS8, Line 41: #define PCIE1_3x2_NUM_LANES 2 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119815): https://review.coreboot.org/c/coreboot/+/53902/comment/a88f6463_9b46648b PS8, Line 57: #define PERST_DELAY_US 1000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119815): https://review.coreboot.org/c/coreboot/+/53902/comment/33de1abe_64af3a77 PS8, Line 58: #define PCIE_MAX_BARS 6 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119815): https://review.coreboot.org/c/coreboot/+/53902/comment/706066af_797f01f0 PS8, Line 154: #define PCIE1_QMP_PHY_PCS_COM 0x01C0EA00 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119815): https://review.coreboot.org/c/coreboot/+/53902/comment/46a51d47_b4f5250b PS8, Line 155: #define PCE1_QPHY_SERDES 0x01C0E000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119815): https://review.coreboot.org/c/coreboot/+/53902/comment/1bfc039b_ed6eddf2 PS8, Line 156: #define PCE1_QPHY_TX0 0x01C0E200 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119815): https://review.coreboot.org/c/coreboot/+/53902/comment/62cb3b53_8a379058 PS8, Line 157: #define PCE1_QPHY_RX0 0x01C0E400 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119815): https://review.coreboot.org/c/coreboot/+/53902/comment/4ad35553_108849f0 PS8, Line 169: #define PCIE_DEV_FUNC (dev,func) PCI_SLOT(devfn) | PCI_FUNC(devfn) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119815): https://review.coreboot.org/c/coreboot/+/53902/comment/1106f954_413f5e2f PS8, Line 169: #define PCIE_DEV_FUNC (dev,func) PCI_SLOT(devfn) | PCI_FUNC(devfn) Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119815): https://review.coreboot.org/c/coreboot/+/53902/comment/8946fc1c_536e1614 PS8, Line 188: #define PCIE_DEV(_bus, _dev, _fn) (0x80000000 | \ Macros with complex values should be enclosed in parentheses
File src/soc/qualcomm/sc7280/pcie_host.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119815): https://review.coreboot.org/c/coreboot/+/53902/comment/c333a43a_be6edc32 PS8, Line 303: pci_ep_cfg_info.config_base = (void*)PCIE1_GEN3x2_CONF; "(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119815): https://review.coreboot.org/c/coreboot/+/53902/comment/24178639_fe99c510 PS8, Line 459: printk(BIOS_INFO,"pcie ep PERST asserted \n"); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119815): https://review.coreboot.org/c/coreboot/+/53902/comment/d5a9bd00_a98a8bb1 PS8, Line 459: printk(BIOS_INFO,"pcie ep PERST asserted \n"); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119815): https://review.coreboot.org/c/coreboot/+/53902/comment/17d65cff_8943f54d PS8, Line 468: printk(BIOS_NOTICE,"pcie ep PERST desserted\n"); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119815): https://review.coreboot.org/c/coreboot/+/53902/comment/0c358ded_4aa1efde PS8, Line 773: if (vend_id == 0xffff || vend_id == 0x0000) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119815): https://review.coreboot.org/c/coreboot/+/53902/comment/eeb13f00_dddf7165 PS8, Line 1140: if(!ret) space required before the open parenthesis '('