build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43614 )
Change subject: drivers/i2c/tas5825m: Add driver for TI TAS5825M amplifier ......................................................................
Patch Set 1:
(14 comments)
https://review.coreboot.org/c/coreboot/+/43614/1/src/drivers/i2c/tas5825m/ta... File src/drivers/i2c/tas5825m/tas5825m.h:
https://review.coreboot.org/c/coreboot/+/43614/1/src/drivers/i2c/tas5825m/ta... PS1, Line 7: int tas5825m_write_block_at(struct device *dev, uint8_t addr, const uint8_t * values, uint8_t length); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43614/1/src/drivers/i2c/tas5825m/ta... PS1, Line 7: int tas5825m_write_block_at(struct device *dev, uint8_t addr, const uint8_t * values, uint8_t length); "foo * bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/43614/1/src/drivers/i2c/tas5825m/ta... File src/drivers/i2c/tas5825m/tas5825m.c:
https://review.coreboot.org/c/coreboot/+/43614/1/src/drivers/i2c/tas5825m/ta... PS1, Line 8: int tas5825m_write_at(struct device *dev, uint8_t addr, uint8_t value) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/43614/1/src/drivers/i2c/tas5825m/ta... PS1, Line 13: int tas5825m_write_block_at(struct device *dev, uint8_t addr, const uint8_t * values, uint8_t length) { line over 96 characters
https://review.coreboot.org/c/coreboot/+/43614/1/src/drivers/i2c/tas5825m/ta... PS1, Line 13: int tas5825m_write_block_at(struct device *dev, uint8_t addr, const uint8_t * values, uint8_t length) { "foo * bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/43614/1/src/drivers/i2c/tas5825m/ta... PS1, Line 13: int tas5825m_write_block_at(struct device *dev, uint8_t addr, const uint8_t * values, uint8_t length) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/43614/1/src/drivers/i2c/tas5825m/ta... PS1, Line 17: if (res < 0) return res; trailing statements should be on next line
https://review.coreboot.org/c/coreboot/+/43614/1/src/drivers/i2c/tas5825m/ta... PS1, Line 22: int tas5825m_set_page(struct device *dev, uint8_t page) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/43614/1/src/drivers/i2c/tas5825m/ta... PS1, Line 26: int tas5825m_set_book(struct device *dev, uint8_t book) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/43614/1/src/drivers/i2c/tas5825m/ta... PS1, Line 28: if (res < 0) return res; trailing statements should be on next line
https://review.coreboot.org/c/coreboot/+/43614/1/src/drivers/i2c/tas5825m/ta... PS1, Line 32: __weak int tas5825m_setup(struct device *dev) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/43614/1/src/drivers/i2c/tas5825m/ta... PS1, Line 37: static void tas5825m_init(struct device *dev) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/43614/1/src/drivers/i2c/tas5825m/ta... PS1, Line 42: if (res) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/43614/1/src/drivers/i2c/tas5825m/ta... PS1, Line 56: static void tas5825m_enable_dev(struct device *dev) { open brace '{' following function definitions go on the next line