build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32188 )
Change subject: WIP: Power resource stub ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/#/c/32188/2/src/drivers/i2c/generic/generic.c File src/drivers/i2c/generic/generic.c:
https://review.coreboot.org/#/c/32188/2/src/drivers/i2c/generic/generic.c@31 PS2, Line 31: static bool i2c_generic_add_gpios_to_crs(struct drivers_generic_power_resource_config *pr_config, line over 80 characters
https://review.coreboot.org/#/c/32188/2/src/drivers/i2c/generic/generic.c@12... PS2, Line 128: if (pr_config && i2c_generic_add_gpios_to_crs(pr_config, config) == true) { line over 80 characters
https://review.coreboot.org/#/c/32188/2/src/include/device/device.h File src/include/device/device.h:
https://review.coreboot.org/#/c/32188/2/src/include/device/device.h@129 PS2, Line 129: unsigned int probed : 1; /* set if device's presence should be probed */ line over 80 characters
https://review.coreboot.org/#/c/32188/2/src/lib/bootblock.c File src/lib/bootblock.c:
https://review.coreboot.org/#/c/32188/2/src/lib/bootblock.c@66 PS2, Line 66: /* walk the device tree and enable devices that contain power resources */ line over 80 characters