build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46771 )
Change subject: mb/google/volteer: Update gpio and devicetree ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/46771/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/elemi/gpio.c:
https://review.coreboot.org/c/coreboot/+/46771/1/src/mainboard/google/voltee... PS1, Line 148: /* H19 : TIME_SYNC0 ==> USER_PRES_FP_ODL */ 'PRES' may be misspelled - perhaps 'PRESS'?
https://review.coreboot.org/c/coreboot/+/46771/1/src/mainboard/google/voltee... PS1, Line 150: trailing whitespace
https://review.coreboot.org/c/coreboot/+/46771/1/src/mainboard/google/voltee... PS1, Line 170: /* S6 : SNDW3_CLK ==> DMIC_CLK0 */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/46771/1/src/mainboard/google/voltee... PS1, Line 170: /* S6 : SNDW3_CLK ==> DMIC_CLK0 */ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/46771/1/src/mainboard/google/voltee... PS1, Line 170: /* S6 : SNDW3_CLK ==> DMIC_CLK0 */ please, no spaces at the start of a line