Attention is currently required from: Anjaneya "Reddy" Chagam, Angel Pons, Kyösti Mälkki. Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Add SMM console log level override ......................................................................
Patch Set 9:
(2 comments)
File src/mainboard/ocp/deltalake/Kconfig:
https://review.coreboot.org/c/coreboot/+/47006/comment/994f845f_590a2022 PS9, Line 68: default y
I am sort of against having this enabled by default, since this adds the entire console and uart dri […]
The behavior is to align with our UEFI analogous firmware that by default the SMI log is disabled so OS wouldn't see them, but if needed we can enable it for debugging without re-building and re-flashing the firmware. It's easier for testing and debugging with one single image that can enable/disable this at run-time by following a reboot to take effect.
Yes the UART needs to be taken care of when SMI interrupting OS and exiting from execution, Rocky has implemented the patch for that but it's not uploaded yet, so far I think his patch works without problem.
File src/mainboard/ocp/deltalake/loglevel_vpd.c:
https://review.coreboot.org/c/coreboot/+/47006/comment/d2a629ec_4e7fd658 PS9, Line 9: int get_console_loglevel(void)
Okay, so with DEBUG_SMI=y console_init() is called once every time SMI is entered. […]
Yes.