Attention is currently required from: Martin Roth. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52475 )
Change subject: mb/hp: Add Compal LA-A992P ......................................................................
Patch Set 7:
(17 comments)
File src/mainboard/hp/hp_15_notebook_pc/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117308): https://review.coreboot.org/c/coreboot/+/52475/comment/1bd08680_c11a5499 PS7, Line 15: /* 00 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x40, 0x00, 0x00, 0x00, 0xff, 0x04, 0x00, 0x00, 0x12, 0x01, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117308): https://review.coreboot.org/c/coreboot/+/52475/comment/033228a6_aee15978 PS7, Line 16: /* 10 */ 0x01, 0x1b, 0x33, 0x1b, 0x00, 0x00, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0x00, 0x04, 0x03, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117308): https://review.coreboot.org/c/coreboot/+/52475/comment/32818234_287f8228 PS7, Line 17: /* 20 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117308): https://review.coreboot.org/c/coreboot/+/52475/comment/b42b5de5_5cbf2047 PS7, Line 18: /* 30 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117308): https://review.coreboot.org/c/coreboot/+/52475/comment/75d3a123_a0887422 PS7, Line 19: /* 40 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117308): https://review.coreboot.org/c/coreboot/+/52475/comment/1ddab21a_3de1d454 PS7, Line 20: /* 50 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117308): https://review.coreboot.org/c/coreboot/+/52475/comment/4e9f73e8_7589fb6b PS7, Line 21: /* 60 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117308): https://review.coreboot.org/c/coreboot/+/52475/comment/a407aec3_9fa3484f PS7, Line 22: /* 70 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117308): https://review.coreboot.org/c/coreboot/+/52475/comment/260c1416_6c655656 PS7, Line 23: /* 80 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117308): https://review.coreboot.org/c/coreboot/+/52475/comment/cf746ba7_af09cfff PS7, Line 24: /* 90 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117308): https://review.coreboot.org/c/coreboot/+/52475/comment/e7e74100_d0742960 PS7, Line 25: /* a0 */ 0x00, 0x04, 0x00, 0x86, 0xc1, 0x00, 0x00, 0x61, 0x63, 0x00, 0x00, 0x08, 0x64, 0x1a, 0x00, 0xf0, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117308): https://review.coreboot.org/c/coreboot/+/52475/comment/3b12afc4_9866bde4 PS7, Line 26: /* b0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x09, 0x00, 0x00, 0x32, 0x02, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117308): https://review.coreboot.org/c/coreboot/+/52475/comment/0785b03f_8cf8f121 PS7, Line 27: /* c0 */ 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117308): https://review.coreboot.org/c/coreboot/+/52475/comment/11b14c0b_c5c7829d PS7, Line 28: /* d0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117308): https://review.coreboot.org/c/coreboot/+/52475/comment/b05c95f6_56f4562a PS7, Line 29: /* e0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117308): https://review.coreboot.org/c/coreboot/+/52475/comment/34ed03f4_b883bb6e PS7, Line 30: /* f0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117308): https://review.coreboot.org/c/coreboot/+/52475/comment/2605d1d9_40f2e06a PS7, Line 35: ec_write (i, dmp[i]); space prohibited between function name and open parenthesis '('