2 Nov
2023
2 Nov
'23
5:38 p.m.
Attention is currently required from: Felix Singer.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78215?usp=email )
Change subject: util/crossgcc/buildgcc: Fix detection of GNAT on recent versions ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File util/crossgcc/buildgcc:
https://review.coreboot.org/c/coreboot/+/78215/comment/c285934b_6ae65ad8 : PS1, Line 1082: if searchtool gnatgcc "Free Software Foundation" nofail > /dev/null; then
Your proposal changes behavior since a value set by the user has less priority now. […]
Acknowledged
--
To view, visit https://review.coreboot.org/c/coreboot/+/78215?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I730bdfda81268d10bd2a41ef5cb4e3810b76a42c
Gerrit-Change-Number: 78215
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Comment-Date: Thu, 02 Nov 2023 16:38:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Martin L Roth gaumless@gmail.com
Gerrit-MessageType: comment