Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48000 )
Change subject: mb/intel/adlrvp: Enable I2S Audio for ADLRVP
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48000/1/src/mainboard/intel/adlrvp/...
File src/mainboard/intel/adlrvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/48000/1/src/mainboard/intel/adlrvp/...
PS1, Line 17: select DRIVERS_SOUNDWIRE_ALC711
remove this too
Done
https://review.coreboot.org/c/coreboot/+/48000/1/src/mainboard/intel/adlrvp/...
File src/mainboard/intel/adlrvp/gpio.c:
https://review.coreboot.org/c/coreboot/+/48000/1/src/mainboard/intel/adlrvp/...
PS1, Line 209:
GPPC_D19 -> NF1 : sorry i noticed this late. please add that too. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48000
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I948b4528ea5c4c378a2e8ff7bb88546da1413df2
Gerrit-Change-Number: 48000
Gerrit-PatchSet: 6
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Vamshi Krishna Gopal
vamshi.krishna.gopal@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 03 Dec 2020 08:02:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Gerrit-MessageType: comment