Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46647 )
Change subject: soc/intel/tigerlake: Configure top swap based on microcode version ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46647/3/src/soc/intel/tigerlake/boo... File src/soc/intel/tigerlake/bootblock/report_platform.c:
https://review.coreboot.org/c/coreboot/+/46647/3/src/soc/intel/tigerlake/boo... PS3, Line 149: microcode_ver == 0x0 Does CAR even work if microcode is not updated? Does it reliably reach this point?
https://review.coreboot.org/c/coreboot/+/46647/3/src/soc/intel/tigerlake/boo... PS3, Line 154: do_board_reset(); Is there a better place for this check? I feel like rebooting in a function called "report_..." is weird?