Attention is currently required from: Ana Carolina Cabral, Maximilian Brune.
Felix Held has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84500?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/amd/birman_plus: Update devicetree
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS4:
rest looks good to me
File src/mainboard/amd/birman_plus/devicetree_glinda.cb:
https://review.coreboot.org/c/coreboot/+/84500/comment/bcf46877_f81791b9?usp... :
PS4, Line 192: device ref gpp_bridge_2_4 on end # GBE
gpp_bridge_2_5 (wwan), gpp_bridge_3_1 (mxm; probably rather a pcie slot though), and gpp_bridge_3_2 (ssd1) seem to be missing here when comparing with the contents of port_descriptors_glinda.c
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84500?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1cc2e4c8f722048b24d84cf782855ae7a8d64c42
Gerrit-Change-Number: 84500
Gerrit-PatchSet: 4
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Alicja Michalska
ahplka19@gmail.com
Gerrit-Reviewer: Ana Carolina Cabral
ana.cpmelo95@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Ana Carolina Cabral
ana.cpmelo95@gmail.com
Gerrit-Comment-Date: Wed, 12 Feb 2025 22:32:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No