Attention is currently required from: Felix Singer, Abhijeet Rao, Maulik V Vaghela, Meera Ravindranath, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59191 )
Change subject: soc/intel/alderlake: Disable VT-d for early silicons
......................................................................
Patch Set 3: -Code-Review
(1 comment)
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/59191/comment/78e26db8_eab7ffa8
PS3, Line 264: cpu_get_cpuid() == CPUID_ALDERLAKE_A0 || CPUID_ALDERLAKE_A1
So if the first part is false, then this is always true since everything greater than 0 is evaluated […]
Ooph my eyes are broken today, thanks Felix 😄
suggestion:
```
const uint32_t cpuid = cpu_get_cpuid();
if (cpuid == CPUID_ALDERLAKE_A0 || cpuid == CPUID_ALDERLAKE_A1)
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59191
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b9b76b6527d8b80777cb7588ce6b12282af7882
Gerrit-Change-Number: 59191
Gerrit-PatchSet: 3
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Abhijeet Rao
abhijeet.rao@intel.corp-partner.google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Abhijeet Rao
abhijeet.rao@intel.corp-partner.google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 11 Nov 2021 21:00:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Gerrit-MessageType: comment