Attention is currently required from: Sridhar Siricilla.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62263 )
Change subject: soc/intel/alderlake: Define Kconfigs for Descriptor Region
......................................................................
Patch Set 5:
(2 comments)
File src/soc/intel/alderlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/62263/comment/6044eaca_65e72961
PS5, Line 372: string "Descriptor Region name"
this should not be user visible.
https://review.coreboot.org/c/coreboot/+/62263/comment/24d47f03_6f1d400c
PS5, Line 371: config SI_DESC_REGION
: string "Descriptor Region name"
: default "SI_DESC"
: help
: Name of Descriptor Region in the FMAP
:
: config SI_DESC_REGION_SZ
: int
: default 4096
: help
: Size of Descriptor Region in the FMAP
Why are those in soc/intel/alderlake? It's not alderlake specific.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62263
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3481acefbda885617607675aef2afbb81c21c77
Gerrit-Change-Number: 62263
Gerrit-PatchSet: 5
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Mon, 28 Mar 2022 12:48:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment