[coreboot-gerrit] Change in coreboot[master]: src: Remove redundant Offset from ASL

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36857 )

Change subject: src: Remove redundant Offset from ASL
......................................................................

Patch Set 3:
> Patch Set 3:
> > Patch Set 3:
> > > Patch Set 3:
> > >
> > > IMO the redundancy is not bad for sanity checking and for readability.
> >
> > [quote] acpi/documents/changes.txt:
> > "when optimization is enabled, the iASL compiler will in fact remove
> > the redundant Offset operators and will not emit any AML code for them."
>
> They won't be in the resulting binary, but the compiler will complain if an Offset is trying to move backwards. An assert statement (that ensures that we're precisely at a given position) would be better, but so far I haven't managed to explain the acpica maintainers that use case in a way that convinces them.

Note that this redundancy is neither a warning nor an error. it is just a remark.
So we also can keep using them.