Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46033 )
Change subject: drivers/wifi: Drop maxsleep parameter from chip config ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46033/1/src/drivers/intel/wifi/wifi... File src/drivers/intel/wifi/wifi.c:
https://review.coreboot.org/c/coreboot/+/46033/1/src/drivers/intel/wifi/wifi... PS1, Line 54: By default, all intel wifi chips wake from S3
SLP_TYP_S3 is 5 for Intel hardware. I don't think 4 is a valid value. […]
My bad. I mixed up the use of PM1_CNT SLP_TYP and ACPI Sx. _PRW only cares about ACPI Sx (we actually have some usages in coreboot that are using SLP_TYP_S3 instead of ACPI_S3 which need to be fixed as follow-ups). Anyways, if a mainboard shows up in coreboot using CNVi/PCIe Intel WiFi and requires maxsleep as S5, it should be easy to bring this maxsleep parameter back. For now, I will keep this as is and can revisit later when required.