Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39971 )
Change subject: security/vboot: Provide stub functions for TPM in bootblock
......................................................................
Patch Set 1: Code-Review-1
Sorry, I don't think this is a good way to fix this. The TPM routines shouldn't get linked into the bootblock in the first place if they're not needed. We probably just need to inline the right function to help the compiler along, please give me a couple of hours to try to come up with an alternative fix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39971
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I888928a6577f4b920b5ee8b65daf23aa46e3aff8
Gerrit-Change-Number: 39971
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 31 Mar 2020 20:03:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment