Attention is currently required from: Martin Roth, Patrick Georgi.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79523?usp=email )
Change subject: libpayload: Remove shell for loops in install Makefile target
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
File payloads/libpayload/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/79523/comment/8ca3443c_56132c5d :
PS2, Line 130: find include -type f -exec install -m644 {} $(DESTDIR)/libpayload/{} ;
I think this wasn't done because -D is a GNU extension. Not sure if anybody still cares, though...
Done
https://review.coreboot.org/c/coreboot/+/79523/comment/2b1a3e9e_ea422f9f :
PS2, Line 131: cd $(coreboottop)/src/commonlib/bsd && find include -type d -exec install -m755 -d $(DESTDIR)/libpayload/{} ;
: c
same here
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79523?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9f9dddfe3f3ceceb6a0510d6dd862351e4b10210
Gerrit-Change-Number: 79523
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Patrick Georgi
patrick@coreboot.org
Gerrit-Comment-Date: Sun, 31 Dec 2023 18:45:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Patrick Georgi
patrick@coreboot.org
Gerrit-MessageType: comment