Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40922 )
Change subject: src/soc/amd/picasso: Add methods to save and restore MTRRs
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40922/4/src/soc/amd/picasso/mtrr.c
File src/soc/amd/picasso/mtrr.c:
https://review.coreboot.org/c/coreboot/+/40922/4/src/soc/amd/picasso/mtrr.c@...
PS4, Line 105: (tmp_sys_cfg.lo & SYS_CFG_MTRR_BITS) != (sys_cfg.lo & SYS_CFG_MTRR_BITS)
I didn't want to add another method and more complexity since it was only for a single register. […]
Sounds good.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40922
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6048b25bd8a32904031ca23953f9726754b5a294
Gerrit-Change-Number: 40922
Gerrit-PatchSet: 4
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 01 May 2020 20:00:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment