Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45000 )
Change subject: Revert "soc/intel/cannonlake: Enable ACPI timer emulation if PM timer is disabled"
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45000/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45000/1//COMMIT_MSG@11
PS1, Line 11: BIOS spec says, emulation shall be always enabled.
BIOS spec actually says that it is *recommended* to always enable the ACPI Timer Emulation, regardless of the OS version. Plus, BIOS is *required* to configure the PM_TMR_EMULATION_CFG MSR 0x121 before BIOS_RESET_CPL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45000
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0d7fa6f9766c7c4e2fa9e846c179adc6a4e1681
Gerrit-Change-Number: 45000
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 05 Oct 2020 17:02:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment