Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40648 )
Change subject: soc/intel/tigerlake: Print HPR_CAUSE0 register and update elog ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40648/3/src/include/elog.h File src/include/elog.h:
https://review.coreboot.org/c/coreboot/+/40648/3/src/include/elog.h@198 PS3, Line 198: /* ME-Initiated Host Reset */ : #define ELOG_TYPE_MI_HRPD 0xb3 : #define ELOG_TYPE_MI_HRPC 0xb4 : #define ELOG_TYPE_MI_HR 0xb5
Should we create separate patch for this header change? […]
+1
https://review.coreboot.org/c/coreboot/+/40648/5/src/soc/intel/tigerlake/elo... File src/soc/intel/tigerlake/elog.c:
https://review.coreboot.org/c/coreboot/+/40648/5/src/soc/intel/tigerlake/elo... PS5, Line 67: ELOG_TYPE_MI_HRPD Where are these ELOG_TYPE_MI_* defined? I don't see them... We will also need to update mosys on the chromeos side to match these new ELOG entries with descriptive strings for the eventlog.