Attention is currently required from: Furquan Shaikh, Derek Huang, Brandon Breitenstein, Curtis Chen.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57138 )
Change subject: src/ec/google/chromeec: Add and modify APIs for USB-C DP ALT mode
......................................................................
Patch Set 10: Code-Review+1
(1 comment)
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/57138/comment/3f9949d4_7436a113
PS10, Line 1567: 1 << Port index
I am curious why the return value is 1 << (port) and not port? […]
In case port 0 is connected, returning `0` means "no port is in an ALT mode", therefore a bitmask was used instead.
Agreed though, checking all the ports at once probably makes sense.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57138
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id11510c1ff58579ae2cddfe5a4d69646fd84f5c3
Gerrit-Change-Number: 57138
Gerrit-PatchSet: 10
Gerrit-Owner: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Curtis Chen
curtis.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Attention: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Attention: Curtis Chen
curtis.chen@intel.corp-partner.google.com
Gerrit-Comment-Date: Fri, 17 Sep 2021 14:33:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment