Attention is currently required from: Alicja Michalska, Felix Singer, Michał Żygowski, Nicholas Chin, Paul Menzel.
Alicja Michalska has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80853?usp=email )
Change subject: mb/erying: Add Erying Polestar G613 Pro (TGL-H)
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/erying/tgl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/80853/comment/5343ae8a_040c7252 :
PS2, Line 197: end
It seems so, my bad for not building locally to test it. […]
For future reference: Yes, it is needed after all.
Removing this entry from devicetree breaks mp_init.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80853?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iffb9e357da2eb686bdcd9a9837df8a60fa94011e
Gerrit-Change-Number: 80853
Gerrit-PatchSet: 5
Gerrit-Owner: Alicja Michalska
ahplka19@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Alicja Michalska
ahplka19@gmail.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Comment-Date: Sat, 30 Mar 2024 20:34:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alicja Michalska
ahplka19@gmail.com
Comment-In-Reply-To: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-MessageType: comment