Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46422 )
Change subject: sec/intel/txt: Bail if var MTRRs cannot snugly cache the BIOS ACM
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/46422/1/src/security/intel/txt/comm...
File src/security/intel/txt/common.c:
https://review.coreboot.org/c/coreboot/+/46422/1/src/security/intel/txt/comm...
PS1, Line 273: * do so will cause a TXT reset with Class Code 5, Major Error Code 2.
No minor? Can you add the chipset generation you used as these error codes tend to change between the chipset generations.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46422
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I480dc3e4a9e4a59fbb73d571fd62b0257abc65b3
Gerrit-Change-Number: 46422
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 15 Oct 2020 08:22:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment