Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43332 )
Change subject: soc/amd/picasso: Add support for DRIVERS_USB_PCI_XHCI
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43332/1/src/soc/amd/picasso/xhci.c
File src/soc/amd/picasso/xhci.c:
https://review.coreboot.org/c/coreboot/+/43332/1/src/soc/amd/picasso/xhci.c@...
PS1, Line 15: mainboard_get_gpe_table
Should this table be added to device tree? It can be used for both configuring non-GPIO SCIs as well as reporting back to any callers.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43332
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice7203831a1f65ed32f3a6392fe02c4b17d42617
Gerrit-Change-Number: 43332
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Thu, 09 Jul 2020 18:45:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment