Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35140 )
Change subject: arch/x86: Refactor CAR_GLOBAL quirk for FSP1.0
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35140/4/src/cpu/x86/car.c
File src/cpu/x86/car.c:
https://review.coreboot.org/c/coreboot/+/35140/4/src/cpu/x86/car.c@82
PS4, Line 82: Pointers to CAR_GLOBALs use relative addressing
Changed the text. After CBMEM comes online dst will be outside _car_region. […]
Done
https://review.coreboot.org/c/coreboot/+/35140/4/src/cpu/x86/car.c@86
PS4, Line 86: dst
Also s/mig_var/offset, not sure if it made this better or worse.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35140
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica877b47e68d56189e9d998b5630019d4328a419
Gerrit-Change-Number: 35140
Gerrit-PatchSet: 7
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 09 Sep 2019 19:28:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment