Sean Rhodes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60229 )
Change subject: starlabs: Convert EC_GPE_SCI to Kconfig ......................................................................
starlabs: Convert EC_GPE_SCI to Kconfig
Convert EC_GPI_SCI to Kconfig option with default value of 0x50 that is used by most boards.
Signed-off-by: Sean Rhodes sean@starlabs.systems Change-Id: I8d47ebe76394fe1bcb217e0c6211db1566f82189 --- M src/ec/starlabs/merlin/Kconfig M src/mainboard/starlabs/labtop/Kconfig M src/mainboard/starlabs/labtop/dsdt.asl 3 files changed, 8 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/60229/1
diff --git a/src/ec/starlabs/merlin/Kconfig b/src/ec/starlabs/merlin/Kconfig index fe94b85..f7e7de5 100644 --- a/src/ec/starlabs/merlin/Kconfig +++ b/src/ec/starlabs/merlin/Kconfig @@ -55,3 +55,7 @@ config EC_VARIANT_DIR string default "merlin" if EC_STARLABS_MERLIN + +config EC_GPI_SCI + hex + default 0x50 diff --git a/src/mainboard/starlabs/labtop/Kconfig b/src/mainboard/starlabs/labtop/Kconfig index 65eb576..858541b 100644 --- a/src/mainboard/starlabs/labtop/Kconfig +++ b/src/mainboard/starlabs/labtop/Kconfig @@ -51,6 +51,9 @@ config DRIVER_TPM_SPI_CHIP default 2
+config EC_GPI_SCI + default 0x6e if BOARD_STARLABS_STARBOOK_TGL + config EC_STARLABS_ADD_ITE_BIN default y
diff --git a/src/mainboard/starlabs/labtop/dsdt.asl b/src/mainboard/starlabs/labtop/dsdt.asl index 8e6de82..aaea03d 100644 --- a/src/mainboard/starlabs/labtop/dsdt.asl +++ b/src/mainboard/starlabs/labtop/dsdt.asl @@ -1,10 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#if CONFIG(BOARD_STARLABS_STARBOOK_TGL) -#define EC_GPE_SCI 0x6e -#else -#define EC_GPE_SCI 0x50 -#endif +#define EC_GPE_SCI CONFIG_EC_GPE_SCI
#include <acpi/acpi.h> DefinitionBlock(