Attention is currently required from: Daniel Peng, Karthik Ramasubramanian, Nick Vaccaro.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78310?usp=email )
Change subject: mb/google/brya/var/marasov: Enable wifi sar table for Intel module ......................................................................
Patch Set 2:
(3 comments)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/78310/comment/325c7e6d_940f2863 : PS2, Line 275: select CHROMEOS_WIFI_SAR if CHROMEOS please follow the alphabetic order please?
File src/mainboard/google/brya/variants/marasov/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/78310/comment/7b16b225_01475e25 : PS2, Line 20: option WIFI_SAR_ID_0 0 what is the usage of this FW config ?
is it more like `absent` ?
File src/mainboard/google/brya/variants/marasov/variant.c:
https://review.coreboot.org/c/coreboot/+/78310/comment/779deb67_6292eacb : PS2, Line 13: printk(BIOS_INFO, "Use wifi_sar_1.hex.\n"); do we really need this msg ?