Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44397 )
Change subject: mb/google/dedede: Replace static Camera ACPI by driver for WDoo
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44397/9/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44397/9/src/mainboard/google/dedede...
PS9, Line 196: ACPI_DT_NAMESPACE_HID
AFAIK the PRP0001 scheme is entirely a coreboot invention that's using a vendor ID that doesn't belo […]
I agree. it may be a non-standard implementation of compatible property, but it is agreed upon in the coreboot and linux kernel community (https://www.kernel.org/doc/html/latest/firmware-guide/acpi/enumeration.html#...).
And I also agree that the current implementation will not work for windows. This implementation is considering the present need/ask and available resources. We also clarified in the beginning of this effort that we will be prioritizing the support for the linux kernel driver. Having said that, it is not our intention to not support windows driver, we can take it up when there is a need for it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44397
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib7e875d297c04f35d4e980ff33d9a3767d2910ac
Gerrit-Change-Number: 44397
Gerrit-PatchSet: 10
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Matt Delco
delco@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Tian Shu Qiu
tian.shu.qiu@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt Delco
delco@chromium.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 08 Sep 2020 18:29:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Varshit B Pandya
varshit.b.pandya@intel.com
Comment-In-Reply-To: Matt Delco
delco@chromium.org
Gerrit-MessageType: comment