Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37660 )
Change subject: ifwitool: Introduce a skip BPDT parameter ......................................................................
Patch Set 2:
(8 comments)
https://review.coreboot.org/c/coreboot/+/37660/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37660/2//COMMIT_MSG@9 PS2, Line 9: apololake nit: apollolake or Apollo lake
https://review.coreboot.org/c/coreboot/+/37660/2//COMMIT_MSG@9 PS2, Line 9: require allow?
https://review.coreboot.org/c/coreboot/+/37660/2//COMMIT_MSG@10 PS2, Line 10: usually in the ifwi binary Isn't that optional?
https://review.coreboot.org/c/coreboot/+/37660/2//COMMIT_MSG@11 PS2, Line 11: BPDT Do you mean IFWI?
https://review.coreboot.org/c/coreboot/+/37660/2//COMMIT_MSG@16 PS2, Line 16: This is useful to extract the Logical Boot Partition : 2 contains in some IFWI to inject it with fmaptool. Just to ensure I understand this correctly. You are using ifwitool with "skip BPDT" parameter to make it use BPDT for LBP2 instead of LBP1 for extracting the sub-partitions within LBP2?
I think the name "skip BPDT" is very confusing. Instead of asking to skip, can this instead accept a parameter which says BPDT # to use? and that BPDT# defaults to 1 for LBP1. Caller is allowed to pass in either 1 or 2 corresponding to the LBP#.
https://review.coreboot.org/c/coreboot/+/37660/2//COMMIT_MSG@23 PS2, Line 23: or third, ... I think IFWI for APL allows only two?
https://review.coreboot.org/c/coreboot/+/37660/2//COMMIT_MSG@23 PS2, Line 23: BPDP BPDT
https://review.coreboot.org/c/coreboot/+/37660/2/util/cbfstool/ifwitool.c File util/cbfstool/ifwitool.c:
https://review.coreboot.org/c/coreboot/+/37660/2/util/cbfstool/ifwitool.c@18... PS2, Line 1870: f:s:vh Why does only create support this option?