Attention is currently required from: Angel Pons, HAOUAS Elyes. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45517 )
Change subject: nb/intel: Introduce MCHBAR accessor functions ......................................................................
Patch Set 41:
(1 comment)
Patchset:
PS41: Looks like we first need to talk about `and_or` vs. `unset_and_set`. It's not just a different terminology, `and_or` also doesn't work well when the compiler adds more type checking.
A deferred inversion of the mask allows the compiler to check the range of the provided value (instead of the integer-promoted result of the inversion). I think this is the way to go if we want to make use of GCC 10's new features and would be happy to review anything in that direction. If the goal is to ignore GCC's new warnings, I would prefer to disable them explicitly.
I don't intend to put any more review effort into patches that introduce error-hiding casts. Feel free to add me as reviewer again if that changed.