Attention is currently required from: Angel Pons, HAOUAS Elyes.
View Change
1 comment:
Patchset:
Patch Set #41:
Looks like we first need to talk about `and_or` vs. `unset_and_set`.
It's not just a different terminology, `and_or` also doesn't work
well when the compiler adds more type checking.
A deferred inversion of the mask allows the compiler to check
the range of the provided value (instead of the integer-promoted
result of the inversion). I think this is the way to go if we want
to make use of GCC 10's new features and would be happy to
review anything in that direction. If the goal is to ignore GCC's
new warnings, I would prefer to disable them explicitly.
I don't intend to put any more review effort into patches that
introduce error-hiding casts. Feel free to add me as reviewer
again if that changed.
To view, visit change 45517. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5fa844a8a13a75d6d802ca48f72c513bfa16d0a5
Gerrit-Change-Number: 45517
Gerrit-PatchSet: 41
Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Comment-Date: Sun, 17 Jan 2021 17:12:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment