15 Feb
2020
15 Feb
'20
4:16 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38918 )
Change subject: vboot/Kconfig: Handle VBNV RTC offset in code ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38918/2/src/vendorcode/google/chrom... File src/vendorcode/google/chromeos/acpi/chromeos.asl:
https://review.coreboot.org/c/coreboot/+/38918/2/src/vendorcode/google/chrom... PS2, Line 79: CONFIG_VBOOT_VBNV_OFFSET - 14, Looks like this code would be added even if !VBOOT_VBNV_CMOS. So if cros checks for 0 here, it might be a problem.
--
To view, visit https://review.coreboot.org/c/coreboot/+/38918
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I928457febd399526fa77108d12b804ca7e53f80b
Gerrit-Change-Number: 38918
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 15 Feb 2020 15:16:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment