[coreboot-gerrit] [M] Change in coreboot[master]: soc/amd/common/acpi: Implement DTTS Proposal

[Tim Van Patten (Code Review)]

Attention is currently required from: Raul Rangel, Jason Nien, EricKY Cheng, Matt DeVillier, Paul Menzel, Eric Lai, Martin Roth, Eric Peers, Jason Glenesk, Dtrain Hsu, Caveh Jalali, Tim Wawrzynczak, Fred Reitberger, Karthikeyan Ramasubramanian, Boris Mittelberg, Felix Held.

Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68471 )

Change subject: soc/amd/common/acpi: Implement DTTS Proposal
......................................................................

Patch Set 63: Code-Review+1

(7 comments)

File src/soc/amd/common/acpi/dptc.asl:

https://review.coreboot.org/c/coreboot/+/68471/comment/ac79e120_aa783e54 
PS53, Line 42: #if CONFIG(FEATURE_DYNAMIC_DPTC)
             :         #include <soc/amd/common/acpi/DTTS.asl>
             : #endif
> Hi Tim […]

Done

File src/soc/amd/common/acpi/dptc.asl:

https://review.coreboot.org/c/coreboot/+/68471/comment/dafa53c3_3eb551cb 
PS59, Line 22:         /* If _SB.DTTS is not present, DTTS is not enabled. */
             :         If (CondRefOf (_SB.DTTS))
             :         {
             :             _SB.DTTS()
             :             Return (Zero)
             :         }
> Thanks your suggestion. […]

Done

https://review.coreboot.org/c/coreboot/+/68471/comment/d918f8ef_b4f76060 
PS59, Line 52:
> Thanks your suggestion. […]

Done

File src/soc/amd/common/acpi/dptc.asl:

https://review.coreboot.org/c/coreboot/+/68471/comment/2534e5a6_81fe01d1 
PS63, Line 21: 
nit: remove extra newline

File src/soc/amd/common/acpi/dtts.asl:

https://review.coreboot.org/c/coreboot/+/68471/comment/10c6f769_3217c8e4 
PS63, Line 9: PRTN,7
nit: add whitespace after `,`

https://review.coreboot.org/c/coreboot/+/68471/comment/b166ac70_57756ebc 
PS63, Line 13: //Set
nit: whitespace after `//`

This applies to the rest of the comments in this file too.

https://review.coreboot.org/c/coreboot/+/68471/comment/46c62891_ee2c1607 
PS63, Line 13: SUT
nit: device