11 Dec
2019
11 Dec
'19
3:21 a.m.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37638 )
Change subject: superio/*: Don't use conf_mode directly ......................................................................
Patch Set 1: Code-Review-1
after removing the includes the structs assigned to ops_pnp_mode are out of scope.
apart from that i like the direction of the patch
--
To view, visit https://review.coreboot.org/c/coreboot/+/37638
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibb94d86b3ee861f44cded469ff58b545dd7311fd
Gerrit-Change-Number: 37638
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 11 Dec 2019 02:21:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment