[coreboot-gerrit] Change in coreboot[master]: util/sconfig: allow to override chip-wrapped devices

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46531 )

Change subject: util/sconfig: allow to override chip-wrapped devices
......................................................................

Patch Set 7:
> Patch Set 7:
> > > I'm not sure if we actually want to allow changing the chip.
> > > Alternatively, we could error out and fix the drivers. Some-
> > > thing like CB:41745 might help.
> >
> > Well, when we turn it around (having the driver inside the device instead of wrapping the device) the problem should be gone. This is what CB:41745 does, right?
>
> It also adds another pointer to a config struct separate from
> the chip's one. It wouldn't solve the problem if trees conflict,
> but could avoid conflicting trees in some cases.

I agree with Nico, this is, as things currently stand, just an error in whoever is writing the devicetrees. Technically, it is wrong to not have both devices wrapped with the same chip driver (sconfig assumes the hierarchy w/r/t devices & chips is the same in that respect)