Attention is currently required from: Felix Held. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48529 )
Change subject: mb/amd/majolica: Add PSP support for board majolica ......................................................................
Patch Set 26:
(3 comments)
File src/mainboard/amd/majolica/Kconfig:
https://review.coreboot.org/c/coreboot/+/48529/comment/661b0208_b35f648a PS13, Line 7: select BOARD_ROMSIZE_KB_16384
i'd put this in a separate patch before this one, since it's not about the psp support itself, but a […]
Done
File src/mainboard/amd/majolica/Kconfig:
https://review.coreboot.org/c/coreboot/+/48529/comment/35676ab6_16d33295 PS20, Line 21: config AMD_FWM_POSITION_INDEX
i wonder why this is dropped in newer versions. […]
Done
File src/mainboard/amd/majolica/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48529/comment/d7501aad_52318117 PS22, Line 7: PHONY+=add_mchp_fw : INTERMEDIATE+=add_mchp_fw
those two lines shouldn't be in here; I guess something went wrong during a rebase. […]
Done