Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30973 )
Change subject: [WIP] src/mainboard/sony: Add Sony VPCEH2K1E ......................................................................
Patch Set 3:
(5 comments)
Notes to self:
https://review.coreboot.org/#/c/30973/3/src/mainboard/sony/vpceh2k1e/Kconfig File src/mainboard/sony/vpceh2k1e/Kconfig:
https://review.coreboot.org/#/c/30973/3/src/mainboard/sony/vpceh2k1e/Kconfig... PS3, Line 33: Specify Nvidia GPU's PCI ID here for the VBIOS
https://review.coreboot.org/#/c/30973/3/src/mainboard/sony/vpceh2k1e/devicet... File src/mainboard/sony/vpceh2k1e/devicetree.cb:
https://review.coreboot.org/#/c/30973/3/src/mainboard/sony/vpceh2k1e/devicet... PS3, Line 5: chip cpu/intel/socket_rPGA989 : device lapic 0x0 on : end : end Recent patch changes this
https://review.coreboot.org/#/c/30973/3/src/mainboard/sony/vpceh2k1e/dsdt.as... File src/mainboard/sony/vpceh2k1e/dsdt.asl:
https://review.coreboot.org/#/c/30973/3/src/mainboard/sony/vpceh2k1e/dsdt.as... PS3, Line 21: #include <arch/acpi.h> Space afterwards
https://review.coreboot.org/#/c/30973/3/src/mainboard/sony/vpceh2k1e/dsdt.as... PS3, Line 31: /* Some generic macros */ Banish
https://review.coreboot.org/#/c/30973/3/src/mainboard/sony/vpceh2k1e/mainboa... File src/mainboard/sony/vpceh2k1e/mainboard.c:
https://review.coreboot.org/#/c/30973/3/src/mainboard/sony/vpceh2k1e/mainboa... PS3, Line 26: remove Banish