Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32588 )
Change subject: intel/fsp1_1: Drop `boot_mode` from `pei_data`
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32588/1/src/drivers/intel/fsp1_1/romstage.c
File src/drivers/intel/fsp1_1/romstage.c:
https://review.coreboot.org/#/c/32588/1/src/drivers/intel/fsp1_1/romstage.c@...
PS1, Line 144: raminit(params, s3wake);
Any reason for not using params->power_state->prev_sleep_state in raminit()?
Thanks. I lost track of all the `params` pointers. You are right,
we already pass this information, I'll update.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32588
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaaad760e8ceca62655f5448c30846cf11959e8e1
Gerrit-Change-Number: 32588
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 06 May 2019 08:43:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frans Hendriks
fhendriks@eltan.com
Gerrit-MessageType: comment