Attention is currently required from: Jason Glenesk, Raul Rangel, Jakub Czapiga, Matt DeVillier, Paul Menzel, Fred Reitberger, Karthik Ramasubramanian, Felix Held.
Grzegorz Bernacki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74267 )
Change subject: soc/amd/mendocino: Add Kconfig option to generate manifest
......................................................................
Patch Set 2:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74267/comment/6a10c15b_3bcb601e
PS1, Line 7: option
Kconfig option
Done
https://review.coreboot.org/c/coreboot/+/74267/comment/2e0f4d15_879bca2b
PS1, Line 7: mendocino
soc/amd/mendocino
Done
https://review.coreboot.org/c/coreboot/+/74267/comment/8670b48e_9983f7d5
PS1, Line 9: This commit adds config, which when enabled adds
: a FSP blob version file to CBFS and enables
: printing the content of the file at ramstage.
Please reflow, so the full line length of 75 characters is used.
Done
File src/soc/amd/mendocino/Kconfig:
https://review.coreboot.org/c/coreboot/+/74267/comment/dee7da42_07e22f95
PS1, Line 488: FSP_VERSION_FILE
Name makes it look like this is a path. […]
Done
https://review.coreboot.org/c/coreboot/+/74267/comment/587d105d_ea86908f
PS1, Line 492: some FSP blobs
I'll add more description in the next version
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74267
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13c9d322735e0979484b120c665fb100cf187eab
Gerrit-Change-Number: 74267
Gerrit-PatchSet: 2
Gerrit-Owner: Grzegorz Bernacki
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 18 Apr 2023 09:40:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Grzegorz Bernacki
Gerrit-MessageType: comment