Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44038 )
Change subject: soc/intel/tigerlake: Add chipset devicetree
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44038/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44038/4//COMMIT_MSG@12
PS4, Line 12: Set a default register value as an example.
I had this initially as an example (setting SaGv to enabled) but removed it later so this line shoul […]
Done
https://review.coreboot.org/c/coreboot/+/44038/3/src/soc/intel/tigerlake/Kco...
File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/44038/3/src/soc/intel/tigerlake/Kco...
PS3, Line 95:
It doesn't need it selected to compile, because all this will do is set up a `struct drivers_intel_w […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44038
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If50269808645ddc019e0d94fa8296df58ab7c367
Gerrit-Change-Number: 44038
Gerrit-PatchSet: 7
Gerrit-Owner: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 08 Oct 2020 20:17:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment