Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38832 )
Change subject: Documentation/ifdtool: modify IFD regions ......................................................................
Patch Set 2:
(6 comments)
https://review.coreboot.org/c/coreboot/+/38832/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38832/2//COMMIT_MSG@7 PS2, Line 7: Documentation/ifdtool: modify IFD regions Doc/ifdtool: Explain how to modify IFD regions
https://review.coreboot.org/c/coreboot/+/38832/2/Documentation/ifdtool/layou... File Documentation/ifdtool/layout.md:
https://review.coreboot.org/c/coreboot/+/38832/2/Documentation/ifdtool/layou... PS2, Line 37: It is possible to adjust the IFD regions on a firmware image or on a Please reflow the added text so that the lines are more or less of the same length as the existing ones.
https://review.coreboot.org/c/coreboot/+/38832/2/Documentation/ifdtool/layou... PS2, Line 71: best practice nit: Not only best practice, the hardware can't handle any finer granularity
https://review.coreboot.org/c/coreboot/+/38832/2/Documentation/ifdtool/layou... PS2, Line 71: allign align
https://review.coreboot.org/c/coreboot/+/38832/2/Documentation/ifdtool/layou... PS2, Line 71: boundry boundary
https://review.coreboot.org/c/coreboot/+/38832/2/Documentation/ifdtool/layou... PS2, Line 93: the the None of these "the" is needed