Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60396 )
Change subject: soc/mediatek/mt8186: Add DDP driver
......................................................................
Patch Set 3:
(2 comments)
File src/soc/mediatek/mt8186/include/soc/ddp.h:
https://review.coreboot.org/c/coreboot/+/60396/comment/ae29a37b_d7c288eb
PS2, Line 145: * 0: Enable clock
please, no space before tabs
Please fix.
https://review.coreboot.org/c/coreboot/+/60396/comment/55663a5e_2b9d7d68
PS2, Line 146: * 1: Clock gating
please, no space before tabs
Please fix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60396
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4fb40832b5dc7a815b37266259b2e3281ee79f1
Gerrit-Change-Number: 60396
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 27 Dec 2021 10:43:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment