Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43623 )
Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................
Patch Set 19: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... PS9, Line 56: PchSerialIoPci
Or we can get CB:43639 in first, your choice.
Done
https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... PS9, Line 46: [PchSerialIoIndexI2C1] = PchSerialIoDisabled, : [PchSerialIoIndexI2C2] = PchSerialIoDisabled, : [PchSerialIoIndexI2C3] = PchSerialIoDisabled, : [PchSerialIoIndexI2C4] = PchSerialIoDisabled, : [PchSerialIoIndexI2C5] = PchSerialIoDisabled, : [PchSerialIoIndexSPI0] = PchSerialIoDisabled, : [PchSerialIoIndexSPI1] = PchSerialIoDisabled, : [PchSerialIoIndexSPI2] = PchSerialIoDisabled, : [PchSerialIoIndexUART0] = PchSerialIoDisabled, : [PchSerialIoIndexUART1] = PchSerialIoDisabled, :
Yes... […]
Done
https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... PS9, Line 220: register "generic.hid" = ""PNP0C50""
Hmm, to me this reads differently here... […]
Done
https://review.coreboot.org/c/coreboot/+/43623/19/src/mainboard/system76/lem... File src/mainboard/system76/lemp9/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43623/19/src/mainboard/system76/lem... PS19, Line 207: on keep the comment here, to keep it in line with the others