Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31834 )
Change subject: ec/google/chromeec: Support AP watchdog flag from Chrome EC ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31834/3/src/ec/google/chromeec/Kconfig File src/ec/google/chromeec/Kconfig:
https://review.coreboot.org/#/c/31834/3/src/ec/google/chromeec/Kconfig@27 PS3, Line 27: config EC_GOOGLE_CHROMEEC_AP_WATCHDOG_FLAG
This should probably be somewhere in soc/mediatek, not here.
Actually, scratch that. I don't really like the way you're hacking this into the MediaTek WDT driver either.
How about we leave this here, and then use it to add a check to src/vendorcode/google/chromeos/watchdog.c#elog_handle_watchdog_tombstone? Then you don't need to change the MTK code at all, and this would work out on any platform as long as you enable the Kconfig.