Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38394 )
Change subject: drivers/i2c/at24rf08c: Tighten count variable type to unsigned integers
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38394/1/src/drivers/i2c/at24rf08c/a...
File src/drivers/i2c/at24rf08c/at24rf08c.c:
https://review.coreboot.org/c/coreboot/+/38394/1/src/drivers/i2c/at24rf08c/a...
PS1, Line 39: printk(BIOS_DEBUG, "i= = %u, j = %u\n", j);
Nitpick: can you trim this down to two times '='? […]
Yes, it doesn’t belong into this commit, and I’ll remove it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38394
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I225d0177b78984783d4f2506873ed220863b0467
Gerrit-Change-Number: 38394
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Idwer Vollering
vidwer@gmail.com
Gerrit-Comment-Date: Tue, 14 Jan 2020 15:26:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Idwer Vollering
vidwer@gmail.com
Gerrit-MessageType: comment