Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37214 )
Change subject: lib: Fix FMAP cache on FSP1.0 platforms
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37214/1/src/lib/fmap.c
File src/lib/fmap.c:
https://review.coreboot.org/c/coreboot/+/37214/1/src/lib/fmap.c@123
PS1, Line 123: destroyed on FspMemoryInit() exit.
That is not true. They are relocated. […]
perhaps wording is incorrect. yeah they are relocated, but CAR is torn down. We cache only mem_region_device, but the payload is located in CAR region that is not CAR variable on its own. So mem_region_device has an invalid wild pointer after fspmemoryinit
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37214
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: 4.11_branch
Gerrit-Change-Id: I9f64c26650fa4c397a0e4835e470ab41922e1290
Gerrit-Change-Number: 37214
Gerrit-PatchSet: 1
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 25 Nov 2019 21:06:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment