[coreboot-gerrit] Change in coreboot[master]: soc/intel/cmn/spi: Add ACPI SSDT extension for fast SPI

[Werner Zeh (Code Review)]

Attention is currently required from: Nico Huber, Subrata Banik, Paul Menzel, Arthur Heymans.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63982 )

Change subject: soc/intel/cmn/spi: Add ACPI SSDT extension for fast SPI
......................................................................

Patch Set 2:

(1 comment)

File src/soc/intel/common/block/spi/spi.c:

https://review.coreboot.org/c/coreboot/+/63982/comment/7138cbf2_cf931d62 
PS1, Line 117: spi_fill_ssdt
> Right, we mustn't add a device with _HID if there is a discoverable
> PCI device.

OK, agree.

And yes, APL is kind of different here as the policy is to hide this device, which is hard coded and not bound to a config switch or the like. Even checking for the availability is not doable here as at the time of PCI enumeration the SPI controller _is_ visible. It will be hidden later.