Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31844 )
Change subject: google/kukui: Enable CHROMEOS_USE_EC_WATCHDOG_FLAG
......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/31844/12/src/mainboard/google/kukui...
File src/mainboard/google/kukui/Kconfig:
https://review.coreboot.org/c/coreboot/+/31844/12/src/mainboard/google/kukui...
PS12, Line 22: config CHROMEOS
: def_bool y
no we can't do this. […]
Ack
https://review.coreboot.org/c/coreboot/+/31844/12/src/mainboard/google/kukui...
PS12, Line 35: CHROMEOS_USE_EC_WATCHDOG_FLAG
one alternative is […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31844
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I053cc7664bbaf0d3fcae26ba9481a0ad700dca90
Gerrit-Change-Number: 31844
Gerrit-PatchSet: 13
Gerrit-Owner: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 26 Aug 2019 08:19:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment