Attention is currently required from: Elyes Haouas, Nico Huber, Paul Menzel.
Nicholas Sudsgaard has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80332?usp=email )
Change subject: device/azalia: Separate codec checking and initialization ......................................................................
Patch Set 6:
(3 comments)
File src/device/azalia_device.c:
https://review.coreboot.org/c/coreboot/+/80332/comment/f797a50a_3b04f4c5 : PS6, Line 259: load_verb
Maybe rather `load_verb_table`. I got a bit confused because we have […]
I can see how the separation is a bit overdone with `get_verb()` and `load_verb()`. I will put those 2 back into `azalia_codec_init()`. 👍
https://review.coreboot.org/c/coreboot/+/80332/comment/e505752f_9b65ee02 : PS6, Line 272: size
It's more of a `count'. But maybe that's something to take care of later.
Maybe it's just me but I have a feeling that the naming is a bit confusing here in general (e.g. `u32 *verb` feels like it should be plural).
File src/include/device/azalia_device.h:
https://review.coreboot.org/c/coreboot/+/80332/comment/01ad8308_f36cdf83 : PS5, Line 13:
It's common to indent the bit definitions.
Done